Skip to content

fix(ext/node): improve assert.fail #29850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

fix(ext/node): improve assert.fail #29850

merged 1 commit into from
Jun 25, 2025

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jun 23, 2025

This PR improves assert.fail compatibility and enables parallel/test-assert-fail-deprecation.js test case.

towards #29801

@kt3k kt3k mentioned this pull request Jun 23, 2025
Open
12 tasks
bartlomieju
bartlomieju approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kt3k kt3k merged commit be3e7f4 into denoland:main Jun 25, 2025
32 of 35 checks passed
@kt3k kt3k deleted the fix-ext-node-fail-deprecation branch June 25, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kt3k @bartlomieju