feat(unstable): add DENO_NODE_CONDITIONS env var #29848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
requested changes
Jun 23, 2025
cli/args/flags.rs
Outdated
| @@ -4574,6 +4574,7 @@ fn lock_args() -> [Arg; 3] { | |||
| fn node_conditions_arg() -> Arg { | |||
| Arg::new("unstable-node-conditions") | |||
| .long("unstable-node-conditions") | |||
| .env("DENO_NODE_CONDITIONS") | |||
There was a problem hiding this comment.
We need to add a lint rule somehow to ban this. Can you pattern off the other code so that env vars only get resolved after loading the env file?
There was a problem hiding this comment.
Sure - how will this work when we stabilize these and they are no longer unstable?
There was a problem hiding this comment.
I guess the same as with UnstableConfig, just stored on the Flags struct
|
Great to see those changes mentioned in the latest video update. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #29586 that
adds a
DENO_NODE_CONDITIONSenv var that allows tospecify conditional exports when the user can't control
CLI flags passed to the command (eg. on Deploy).