fix: import.meta.resolve - do not error for non-existent files in npm packages
#29741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Jun 16, 2025
Comment on lines
+639
to
+640
| // but the repl may also end up here and it won't have | ||
| // a referrer so create a referrer for it here |
There was a problem hiding this comment.
6 years and counting since we can't solve this :sigh:
| @@ -647,7 +652,9 @@ impl DenoPluginHandler { | |||
| json_module.specifier.clone(), | |||
| esbuild_client::BuiltinLoader::Json, | |||
| ), | |||
| deno_graph::Module::Wasm(_) => todo!(), | |||
| deno_graph::Module::Wasm(_) => { | |||
| bail!("Wasm modules are not implemented in deno bundle.") | |||
There was a problem hiding this comment.
@nathanwhit are you planning to address this before 2.4?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This further improves
import.meta.resolveto not error in many more scenarios (better alignment with Node).node:non-existent)Additionally, this defers resolving npm specifiers until loading for dynamic imports in order to have
prepare_loadproperly install them loading. Before it could potentially error when loading the same npm specifier on multiple workers (reason for flakyspecs::npm::worker_shutdown_during_npm_import).