fix(bench): Make output table markdown compatible #29532
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the format of the table outputted by
deno bench
to be markdown compatible.deno coverage
also outputs a table to the console, and there might very well be other commands too. However, bothbench
andcoverage
has their own logic for building up and outputting the table. So there is an opportunity to create a more generic (markdown) table builder/generator. However, as I'm not too familiar with the codebase, I did not do any generalization, and tried to keep the changes as minimal as possible to produce a markdown compatible table with the existing logic.Example of current output (without this change):
Example of new output (with this change):
Related #29533
Closes #29466