fix(ext/node): various node:sqlite fixes

[littledivy]

Changes:

• Set #[undefined] retval for open, set_allow_bare_named_parameters and set_read_bigint
• Make readOnly property optional in DatabaseSync
• Rewrite error handling and return Node error objects with code properties.

Todo:

• Figure out how to do Node arg validation errors in op2 feat(op2): add #[validate(fn)] for custom arg validation deno_core#1137

[bartlomieju]

Unrelated to this PR, but I think the API should be OPEN_STRING.from_scope(scope) - the unwrap shouldn't be necessary here

[bartlomieju]

A few comments but overall LGTM - really solid work

[bartlomieju]

Just to be 100% sure - have you verified that these actually pass and are not silently ignored by deno test is something goes wrong? If so, our support for node:test is getting pretty good 💪

[littledivy]

yep, went through fixing each test as the previous one passed so it does actually work!

[littledivy]

Something weird happening in this new test file (parallel/test-sqlite-session.js):

running 14 tests from ./test/parallel/test-sqlite-session.js
creating and applying a changeset ... ok (0ms)
database.createSession() - closed database results in exception ... ok (0ms)
session.changeset() - closed database results in exception ... ok (0ms)
database.applyChangeset() - closed database results in exception ... ok (0ms)
database.createSession() - use table option to track specific table ... ok (0ms)
conflict resolution ...
  database.applyChangeset() - SQLITE_CHANGESET_CONFLICT conflict with default behavior (abort) ... ok (5ms)
  database.applyChangeset() - SQLITE_CHANGESET_CONFLICT conflict handled with SQLITE_CHANGESET_ABORT ... ok (4ms)
  database.applyChangeset() - SQLITE_CHANGESET_DATA conflict handled with SQLITE_CHANGESET_REPLACE ... ok (4ms)
  database.applyChangeset() - SQLITE_CHANGESET_NOTFOUND conflict with SQLITE_CHANGESET_OMIT ... ok (3ms)
  database.applyChangeset() - SQLITE_CHANGESET_FOREIGN_KEY conflict ... ok (3ms)
  database.applyChangeset() - SQLITE_CHANGESET_CONSTRAINT conflict ... ok (2ms)
  conflict resolution handler returns invalid value ... ok (2ms)
  conflict resolution handler throws ... ok (0ms)
conflict resolution ... ok (12ms)
database.createSession() - filter changes ... ok (0ms)
database.createSession() - specify other database ... ok (0ms)
database.createSession() - wrong arguments ... ok (0ms)
database.applyChangeset() - wrong arguments ... ok (0ms)
session.patchset() ... ok (0ms)
session.close() - using session after close throws exception ... ok (0ms)
session.close() - after closing database throws exception ... ok (0ms)
session.close() - closing twice ... ok (0ms)

"parallel/test-sqlite-session.js" failed:



You can repeat only this test with the command:

  ./target/debug/deno test --config tests/config/deno.json -A tests/node_compat/test.ts -- parallel/test-sqlite-session.js

All tests pass but its still reporting as failed with no output. I've reverted the test for now from CI.

[bartlomieju]

Let's go