feat: Picture Gallery #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Greptile Overview
Summary
Adds a picture gallery component featuring image carousels for DeltaHacks 9, 10, and 11 events. The implementation uses Embla Carousel with autoplay functionality and navigation controls.
Key Changes:
- New
Gallerycomponent as main container - New
GalleryItemcomponent with three variants (DH9, DH10, DH11) - JSON configuration file for gallery images
- Added embla-carousel dependencies
Issues Found:
- PR description missing required
resolves #issue-idreference - Multiple instances of hardcoded rem values violating pixel-based sizing guidelines
- Hardcoded hex colors (
#FFDEA9,#D69E66) instead of Tailwind CSS variables - Using absolute positioning for layout elements
Confidence Score: 3/5
- This PR is functional but has several style guideline violations that should be addressed
- The component implementation is solid with proper React patterns and carousel integration, but violates multiple custom style rules including hardcoded sizing, colors, and absolute positioning. These are non-critical style issues that won't break functionality but should be fixed for consistency.
- Pay attention to
src/components/Gallery.tsxandsrc/components/GalleryItem.tsxfor style guideline compliance
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| src/components/Gallery.tsx | 3/5 | Main gallery container with layout setup - contains hardcoded colors and uses absolute positioning |
| src/components/GalleryItem.tsx | 3/5 | Gallery carousel items for DH9/10/11 - multiple style violations including hardcoded rem values and hex colors |
| src/assets/gallery/gallery.json | 5/5 | Data structure for gallery images - clean implementation with proper structure |
4 files reviewed, 5 comments
AnkushSarkar10
force-pushed
the
ankush/gallery
branch
from
3655e4a to
4f05eb9
Compare
Member
|
@AnkushSarkar10 Address the comments by Gerptile, the ones about hardcoded sizing and colors is valid and against our coding style. |
Contributor
Author
addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picture Gallery Component
Add each pictures for DH9, DH10 and DH11 under
public/galleryPicsand add the filenames for the pictures insrc/assets/gallery/gallery.json.