Allow providing TlsCertificates when creating a redis Manager #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bikeshedder
added
enhancement
bikeshedder
force-pushed
the
main
branch
3 times, most recently
from
7a9da3d to
f713c85
Compare
Author
|
Hi @bikeshedder. Is anything blocking this PR from being merged? I’m happy to make any changes needed to move it forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to use TLS with
deadpool_redisby providing theTlsCertificatesinstance when creating a Manager.An alternative would be to make it possible to create a
Managerdirectly from aClient. However, to me it looks like providing theTlsCertificatesaligns better with what other deadpool crates do.The original issue (#404) also suggests that
deadpool_redis::Configcould have atls_paramsfield.This appears to be tricky, as the
TlsConnParamsstruct is not exposed directly by therediscrate.Closes #404.