Feature/postgres dynamic config #405
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aiden-Ziegelaar
force-pushed
the
feature/postgres-dynamic-config
branch
from
73d7870 to
b029321
Compare
Author
|
@bikeshedder I now have a use case for this. Is the approach along the lines of what you were looking for? If so I'll clean it up, if not I'll work on whatever the new direction is as I have a vested interest in this feature. |
Collaborator
|
Sorry for taking so long. I'm currently in crunch mode for a project with deadline next Monday. I'll revisit this next week! |
bikeshedder
added
enhancement
bikeshedder
force-pushed
the
main
branch
3 times, most recently
from
7a9da3d to
f713c85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for dynamic config providers to Postgres as a proof of concept.
Related to: #402
Error likely needs to be more generic than
tokio_postgres::Erroras the config provider itself likely also has error conditions.Needs a lot of cleanup, not ready to be merged.