-
Notifications
You must be signed in to change notification settings - Fork 185
[WIP] Add deadpool-arangodb #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@bikeshedder do you maybe have an idea what my problem with |
That variant was added back by accident when merging the arangodb PR.
`arangos` depends on `serde` with the `derive` feature anyways so it is of no use making this optional.
|
When running the tests you had to add I just fixed that by making the I also rebased the code on Only two issues remain: https://github.com/bikeshedder/deadpool/actions/runs/1416599665 btw. I would recommend against switching implementations via a feature gates in |
|
Yeah, i also not exactly a fan of misusing feature gates like that, but CI fails
|
2f4d3ba to
b1cf396
Compare
|
It's been quite some time since I last visited this. This was basically impossible to merge into the existing repository due to the workspace and the way tests were excuted. Since the removal of the workspace (#429) and a complete overhaul of the CI configuration adding this to the codebase should be a non-issue. If anyone wants to work on this and refactor the code so it can be merged into |
7a9da3d to
f713c85
Compare
This adds
deadpool-arangodbto the repository.I have marked the PR as
WIP, because there is still a problem withuse serde_1::Deserialize;being marked asunresolved importintests/arangodb.rsand i can't figure out why.I added
BuildError::Configback todeadpool, becausearangorsdoes not use a config struct and as such does not have a config error that i could use for the case the pool was configured wrongly. If you prefer, we can leaveBuildError::Configout and i can try adding such a value upstream (in arangors).Another point is, i had to use the newest
arangorsrev from git, to avoid a build error in the release crate version, coming from thetyped-builderdependency, which afaik published a breaking change without adhering to semver.Addresses #94