Skip to content

Conversation

@russellsteadman
Copy link
Contributor

Fix for issue #109 as discussed in #109 (comment). Also bumped patch version of esm2umd to remove 2 security vulnerabilities.

@dcodeIO
Copy link
Owner

dcodeIO commented Apr 15, 2023

I guess it's not a problem when the UMD typings reexport an export default via export =?

import Long from "../index.js";
export = Long;

@russellsteadman
Copy link
Contributor Author

I think that is the case. This might be good to test out -- I can add in some tests / just independently confirm. Currently though the package cannot be imported when using ESM and TypeScript. @dcodeIO

@russellsteadman
Copy link
Contributor Author

@dcodeIO This does work when I tested it for both CommonJS and ESM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants