getInstance is not respecting cmdOptions correctly

[BorntraegerMarc]

I'm submitting a...

• Bug report
• Feature request
• Question

Current behavior

With this PR #555 we introduced the feature to pass in cmdOptions programatically. So I included it in my project like this:

dbMigrate.getInstance(true, {
            cwd: '../komed-emr',
            env: 'dev',
            cmdOptions: {
                'migrations-dir': './build/src/migrations'
            }
});

But I noticed that it does not work. The cmdOptions actually never are considered. So I added in this line: https://github.com/db-migrate/node-db-migrate/blob/master/lib/commands/set-default-argv.js#L101 a console.log: console.log(internals);

This was the output:

{ onComplete: [Function],
  migrationProtocol: 1,
  isModule: true,
  plugins: { overwrite: [Function: overwrite], hook: [Function: hook] },
  dbm:
   {  },
  currentEnv: 'dev',
  cwd: '../komed-emr' }

As seen the passed in cmdOptions are never included.

Expected behavior

The cmdOptions are included and passed into the method.

I tried to debug the lib but couldn't find the root cause. Maybe you @wzrdtales could point me again to the place where the bug occurs and I could do a new PR to fix it.

Environment

db-migrate version: 0.10.6
db-migrate driver with versions: mongodb 1.4.0 

Additional information:
- Node version: v8.9.1  
- Platform: Windows 

Others:

[BorntraegerMarc]

Friendly ping to @wzrdtales :)

[wzrdtales]

Argh...

Actually internals does not include the options object itself, but evaluates bits of it here:

node-db-migrate/api.js

Lines 48 to 64 in efb8f36

	if (typeof options === 'object') {
	if (typeof options.config === 'string') {
	internals.configFile = options.config;
	} else if (typeof options.config === 'object') {
	internals.configObject = options.config;
	}
	if (typeof options.env === 'string') internals.currentEnv = options.env;
	if (typeof options.cwd === 'string') internals.cwd = options.cwd;
	else internals.cwd = process.cwd();
	} else internals.cwd = process.cwd();
	if (typeof isModule === 'function') {
	this.internals.onComplete = isModule;
	setDefaultArgv(this.internals);
	} else setDefaultArgv(this.internals, isModule);

So this is where the bug sits :/

[dschinkel]

usage of it, an example here in case this helps anyone: 767