Copy-DbaDbCertificate - Fix command and test #9831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niphlod
reviewed
Sep 3, 2025
|
|
||
| # The exported files are only readable by the source instance account | ||
| # But for the restore they need to be readable by the targe instance account | ||
| # Current solution is to try to make them readable to everyone and remove them after the restore |
There was a problem hiding this comment.
isn't the whole premise to use a share that has certs in there useful for disaster recovery scenario ? the deletion in here changes decisevely, as "before" it was just in case of errors (catch), while now it's in each and every case (finally)
There was a problem hiding this comment.
Only newly created cert files that where created by the backup part are deleted. If there are cert files present, then $usingtempfiles is true and the files are not deleted. In our tests we don't have files there so we can only test the Copy- (backup + restore) path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not the best solution, but it should work for now.
We need a new lab to test all the Copy- commands (and all commands related to AGs and Mirrring) with 4 maschines: 2 with the source and targe SQL Server instance, one from where we run dbatools and one with the fileshare. We then might find some more bugs...