Refactor test scenarios

[andreasjordan]

Let me test some ideas from #10069

Looks good to me. @niphlod - what do you think?

How can we trigger an complete test run on this branch?

[potatoqualitee]

Will wait for niph's approval 👍🏼

[potatoqualitee]

i do not know how to trigger a whole run 😅 let me see what i can do. I think ill make a branch off of this and then push bc it runs my entire branches

https://ci.appveyor.com/project/dataplat/dbatools/builds/53297302

[potatoqualitee]

Looks like one command keeps failing Set Parameter something, unsure if related.

[potatoqualitee]

Path : Set-DbaStartupParameter/Validate command functionality/Ensure the startup params are not duplicated when more than one server is modified in the same invocation
Name : It Ensure the startup params are not duplicated when more than one server is modified in the same invocation
Result : Failed
Message : ErrorRecord: Expected 1, but got 2.
StackTrace :
RawErrorRecord : Expected 1, but got 2.
Uploading artifact DetailedTestFailures_Pester5.json (1,073 bytes)...100%
1 tests failed.

[andreasjordan]

Set-DbaStartupParameter uses instance1 and instance2 and was part of the scenario service_restarts. As I removed the scenario, the test is now autodetected into scenario default which should work. But the test needs refactoring anyway and is a good example of instanceMulti, so I will create a new scenario for it and see if it passes.

[andreasjordan]

Now I see the problem. The test uses instances 1 and 2, but the scenario service_restarts only spins up instances 2 and 3. So the test was never working correctly, but we have not noticed because we do not look at the details of the test runs.

[andreasjordan]

Now the test works as expected.

Next steps:

• Move more tests that use multiple instances to scenario MULTI.
• Add scenario SINGLE and move all tests that only uses a single instance to that scenario and test the scenario against the SQL2017 instance to see if they all work there.

Later we could try to use another base image that has newer SQL Server versions. Or build our own image with two instances of version 2022 or 2025. Then we could also enhance the AG tests.

[andreasjordan]

But I will pause this now and wait for @niphlod to give feedback.