apply codecommit:GitPull permission properly #1887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrkalos
force-pushed
the
fix/gitpull_policy
branch
from
b86dbe1 to
1917983
Compare
wliu03
reviewed
Dec 11, 2025
There was a problem hiding this comment.
should the resource include {self.region}:{self.account}
Contributor
Author
There was a problem hiding this comment.
I thought about it but people might have their repo in a different region and not necessarily in the same that data.all is deployed to.
There was a problem hiding this comment.
Make sense, looks good to me, thanks for the code change
wliu03
approved these changes
Dec 11, 2025
There was a problem hiding this comment.
Make sense, looks good to me, thanks for the code change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
apply
codecommit:GitPullto the correct resource