Skip to content

chore(coinbase): disable for uk storefonts #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 9, 2024
Merged

chore(coinbase): disable for uk storefonts #640

merged 3 commits into from
Mar 9, 2024

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Mar 7, 2024

Issue being fixed or feature implemented

  • We need to disable Coinbase in the UK temporarily

What was done?

  • Renamed Portal to BuySellPortal to avoid confusion with other Portals and align with Android.
  • Refactored ServiceDataProvider to simplify the logic.
  • Disabled Coinbase for UK storefronts.

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf March 7, 2024 08:39
@Syn-McJ Syn-McJ self-assigned this Mar 7, 2024
pankcuf
pankcuf suggested changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syn-McJ Syn-McJ merged commit ab8df5e into dashpay:develop Mar 9, 2024
@Syn-McJ Syn-McJ deleted the chore/disable-coinbase-uk branch March 9, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@pankcuf pankcuf pankcuf approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Syn-McJ Syn-McJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Syn-McJ @pankcuf