fix(coinbase): don't paginate an empty page #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Syn-McJ merged 1 commit into dashpay:develop from Syn-McJ:fix/coinbase-select-coin

Nov 17, 2023

Member

Syn-McJ commented Nov 17, 2023

Issue being fixed or feature implemented

Coinbase request is stuck because it tries to fetch an empty URL.

What was done?

Empty URL check

How Has This Been Tested?

Breaking Changes

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have made corresponding changes to the documentation

For repository code-owners and collaborators only

I have assigned this pull request to a milestone


          fix: don't paginate empty page

e169da0

Syn-McJ requested a review from pankcuf

November 17, 2023 05:26

Syn-McJ self-assigned this

pankcuf approved these changes

View reviewed changes

Contributor

pankcuf left a comment

Lgtm

Syn-McJ merged commit 9290ff9 into dashpay:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet