feat(dashpay): integrate DashPay UI into Send screen and Receive tab #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syn-McJ
commented
Sep 19, 2023
| @@ -20,12 +20,19 @@ import UIKit | |||
| // MARK: - ReceiveContentView | |||
|
|
|||
| @objc(DWReceiveContentView) | |||
| final class ReceiveContentView: UIView { | |||
| final class ReceiveContentView: UIStackView { | |||
There was a problem hiding this comment.
StackView works better here for variable content size (username can be hidden if no identity created).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
In DashPay, the Send screen should have the contact userpic and username instead of the destination address. The Receive tab should have the username under the address.
What was done?
ProvideAmountViewControllerUI to display contact info if not null.ReceiveContentViewUI to include the username.ReceiveContentViewcontent is adjusted on small screens to fit into SE format.How Has This Been Tested?
QA
Breaking Changes
Checklist:
For repository code-owners and collaborators only