Skip to content

refactor: Payment flow #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 24, 2023
Merged

refactor: Payment flow #593

merged 4 commits into from
Aug 24, 2023

Conversation

tikhop
Copy link
Contributor

@tikhop tikhop commented Aug 24, 2023

Issue being fixed or feature implemented

Payment flow

What was done?

  • Fix an issue when tab bar get blocked after tx
  • Hide keyboard after 'Enter Address' screen

How Has This Been Tested?

QA/Manually

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@tikhop tikhop marked this pull request as ready for review August 24, 2023 14:54
@tikhop tikhop requested a review from Syn-McJ August 24, 2023 14:54
Syn-McJ
Syn-McJ approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tikhop tikhop merged commit 1dfac76 into develop Aug 24, 2023
@tikhop tikhop deleted the feature/refactor-payment-flow branch August 29, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Syn-McJ Syn-McJ Syn-McJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tikhop @Syn-McJ