Skip to content

fix: Switching currency in settings should update currency on Home Screen #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2023
Merged

fix: Switching currency in settings should update currency on Home Screen #546

merged 1 commit into from
May 2, 2023

Conversation

tikhop
Copy link
Contributor

@tikhop tikhop commented May 1, 2023

Issue being fixed or feature implemented

Switching currency in settings should update currency on Home Screen

What was done?

  • Send notification when fiat currency code changes

How Has This Been Tested?

Manually

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@tikhop tikhop changed the base branch from master to develop May 1, 2023 13:55
@tikhop tikhop requested a review from Syn-McJ May 1, 2023 13:55
@tikhop tikhop marked this pull request as ready for review May 1, 2023 13:56
Syn-McJ
Syn-McJ approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@tikhop tikhop merged commit 22d1a2b into develop May 2, 2023
@tikhop tikhop deleted the fix/reload-selected-currency branch May 2, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Syn-McJ Syn-McJ Syn-McJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tikhop @Syn-McJ