feat(crowdnode): Withdrawal confirmation dialog #516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 15, 2023 13:17
Syn-McJ
commented
Feb 21, 2023
| @@ -127,7 +127,6 @@ public final class CrowdNode { | |||
| init() { | |||
| masternodeAPY = DWEnvironment.sharedInstance().apy.doubleValue | |||
| crowdnodeAPY = masternodeAPY * 0.85 | |||
| accountAddress = prefs.crowdNodeAccountAddress ?? "" // Restore from user default | |||
There was a problem hiding this comment.
This seems to be causing some problems. When we change the network, sometimes the saved address sticks for some reason and we get the wrong state for CrowdNode.
I figure we can get the saved address from the FullCrowdNodeSignUpTxSet directly and keep the normal restoring logic in here to avoid issues.
Syn-McJ
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Because we request CrowdNode withdrawals in percentage from the total balance, the amount user requested can be different from the received amount.
We want to reflect this in UI as a confirmation dialog showing the final amount.
What was done?
How Has This Been Tested?
QA
Breaking Changes
Checklist:
For repository code-owners and collaborators only