Skip to content

feat(crowdnode): Combine transactions #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Feb 8, 2023
Merged

feat(crowdnode): Combine transactions #500

merged 26 commits into from
Feb 8, 2023

Conversation

tikhop
Copy link
Contributor

@tikhop tikhop commented Feb 7, 2023

Issue being fixed or feature implemented

Combine Create CrowdNode account transactions into one

What was done?

  • Show "Create CrowdNode Account" item on home screen
  • Show "Create CrowdNode Account" transaction details screen
  • Refactor data provider and data source for transaction lists
  • Redesign transaction item on home screen

How Has This Been Tested?

Manually, QA

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

tikhop added 25 commits January 31, 2023 19:52
@tikhop
feat(crowdnode): Show 'Create Account' cell on home screen
2014b5c
@tikhop
feat(ui): Use swift version of UIView+DWReuseHelper extension
29b8bd2
@tikhop
refactor(ui): Move tx details cells from storyboard to xibs
7159435
@tikhop
refactor(ui): Introduce base tx details controller and move out from …
bc03934 
…storyboard implementation
@tikhop
chore: Code cleanup
76bd5c1
@tikhop
feat(ui): Implement shortcut methods for tableView for quick nib/clas…
eb66907 
…s registration
@tikhop
feat: Bring some useful methods into DSTransaction extension
7e8aaae
@tikhop
feat(ui): When presenting tx details use methods from DSTransaction e…
854472f 
…xtension
@tikhop
feat(ui): New design and implementation of 'DWTxListTableViewCell'
c8e8f31
@tikhop
feat(crowdnode): Working on Create Account Transaction Details Screen
76e4ec4
@tikhop
feat(crowdnode): Show Create Account transaction details
d73c0cc
@tikhop
refactor: Avoid using 'DSTransaction' object in UI
40ddcc9
@tikhop
chore: Rewrite 'DWTransactionListDataSource' in swift
29697ba
@tikhop
chore: Remove unused imports
7241b08
@tikhop
refactor(ui): Avoid using 'DSTransaction' in UI, by introducing 'Tran…
cbafdbc 
…saction' struct that wraps 'DSTransaction' and will provides all necessary getters
@tikhop
refactor(ui): Use 'Transaction' instead of 'DSTransaction' on home sc…
9611e91 
…reen
@tikhop
refactor: Drop usage of 'DWTransactionListDataProvider' within DWCSVE…
246cdf1 
…xporter
@tikhop
refactor: Don't use 'DWTransactionListDataProvider' to get a transact…
9e253be 
…ion direction
@tikhop
refactor: Don't use 'DWTransactionListDataProvider' if possible
5859255
@tikhop
feat(crowdnode): Show combined transaction
3c06fa1
@tikhop
feat(crowdnode): Show real data inside 'CNCreateAccountTxDetailsViewC…
57e4122 
…ontroller' and 'CNCreateAccountCell'
@tikhop
chore: Update localization files
1a74d06
@tikhop
feat(crowdnode): Save CrowdNode account address in user defaults
86f2d4e
@tikhop
feat(crowdnode): Improve recognition of Top Up transaction
548ce33
@tikhop
chore: Bump up build number
dd7d8fa
@tikhop tikhop requested a review from Syn-McJ February 8, 2023 06:55
@tikhop tikhop marked this pull request as ready for review February 8, 2023 06:56
Syn-McJ
Syn-McJ approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@tikhop tikhop merged commit ac9c752 into feature/crowdnode Feb 8, 2023
@tikhop tikhop deleted the feature/crowdnode-combine-transactions branch February 8, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Syn-McJ Syn-McJ Syn-McJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tikhop @Syn-McJ