Skip to content

Prepare for build_runner changes. #2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Prepare for build_runner changes. #2633

wants to merge 3 commits into from

Conversation

davidmorgan
Copy link

No description provided.

@davidmorgan davidmorgan force-pushed the trying-build-runner branch from 802c41f to 5a4ca2b Compare June 13, 2025 15:42
@davidmorgan davidmorgan mentioned this pull request Jun 13, 2025
Merged
@davidmorgan davidmorgan force-pushed the trying-build-runner branch from 5a4ca2b to 193f031 Compare June 13, 2025 16:02
@davidmorgan davidmorgan marked this pull request as ready for review June 14, 2025 09:05
@davidmorgan davidmorgan requested a review from srujzs June 14, 2025 09:06
srujzs
srujzs approved these changes Jun 14, 2025
View reviewed changes
Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nshahan Is this related to some of the errors we were seeing with Succeeded not being logged as well?

srujzs
srujzs reviewed Jun 14, 2025
View reviewed changes
Copy link
Contributor

@srujzs srujzs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a rough idea on when these can go back to published builds/an issue to track? I expect to release a new version of DWDS in the next few weeks and I'm guessing using overrides for a published package is not a good idea.

@davidmorgan
Copy link
Author

Thanks!

I'm pretty much ready to publish, so I guess Monday or Tuesday :)

Shall I go ahead and merge it?

@srujzs
Copy link
Contributor

srujzs commented Jun 15, 2025

Got it, that sounds good to me then. Go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujzs srujzs srujzs approved these changes

Assignees
No one assigned
Labels
changelog-not-required package:webdev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidmorgan @srujzs