[native_toolchain_c] cl.exe path with space #2870
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
dongfengweixiao
changed the title
dcharkes
reviewed
Dec 18, 2025
Collaborator
dcharkes
left a comment
dcharkes
left a comment
There was a problem hiding this comment.
Is there a way to trigger this in a test on the GitHub actions?
dongfengweixiao
force-pushed
the
header_path_with_space
branch
from
c229fc7 to
16f7776
Compare
dongfengweixiao
changed the title
When the Visual Studio C++ compiler (cl.exe) is installed in a path containing spaces (e.g., the default "C:\Program Files\Microsoft Visual Studio\2022\..."), the build system failed to execute it correctly. The command was invoked without proper quoting, leading to an error: 'C:\Program' is not recognized as an internal or external command Signed-off-by: Dee HY <[email protected]>
dongfengweixiao
force-pushed
the
header_path_with_space
branch
from
16f7776 to
c77845e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the runInShell parameter, I have preserved the original logic as much as possible, only setting runInShell to false when the executable file path contains spaces. I believe this change will better align with the expected behavior.
Contribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.