Skip to content

Conversation

@mosuem
Copy link
Member

@mosuem mosuem commented Dec 25, 2025

  • Move and fix workflow files, labeler.yaml, and badges in the README.md
  • Rev the version of the package, so that pub.dev points to the correct site
  • Add a line to the changelog:
* Move to `dart-lang/labs` monorepo.
  • Add the package to the top-level readme of the monorepo:
| [timezone](pkgs/timezone/) | Time zone databases and time zone aware `DateTime`. | [![package issues](https://img.shields.io/badge/issues-4774bc)](https://github.com/dart-lang/tools/issues?q=is%3Aissue+is%3Aopen+label%3Apackage%3Atimezone) | [![pub package](https://img.shields.io/pub/v/timezone.svg)](https://pub.dev/packages/timezone) |
> [!IMPORTANT]  
> This repo has moved to https://github.com/dart-lang/labs/tree/main/pkgs/timezone
  • Publish using the autopublish workflow
  • Push tags to GitHub using
git tag --list 'timezone*' | xargs git push origin
  • Close open PRs in dart-lang/timezone with the following message:
Closing as the [dart-lang/timezone](https://github.com/dart-lang/timezone) repository is merged into the [dart-lang/labs](https://github.com/dart-lang/labs) monorepo. Please re-open this PR there!
  • Transfer issues by running
dart run pkgs/repo_manage/bin/report.dart transfer-issues --source-repo dart-lang/timezone --target-repo dart-lang/labs --add-label package:timezone --apply-changes

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

srawlins and others added 23 commits April 28, 2025 15:28
for good practice and clean code

I faced an inconvenienced because local time in my  flutter app was changed unexpectedly. That was because initializeDatabase() function silently change _local to _UTC . using setLocalLocation() for that makes debugging easier
Clarified that package does not provide current timezone
Replace direct assignment with setLocalLocation method.
@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Dec 25, 2025
@google-cla
Copy link

google-cla bot commented Dec 25, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mosuem mosuem requested a review from brianquinlan December 25, 2025 17:20
@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:appengine 0.13.11 already published at pub.dev
package:gcloud 0.9.0 already published at pub.dev
package:googleapis_firestore_v1 0.1.0-wip WIP (no publish necessary)
package:native_synchronization 0.3.1 already published at pub.dev
package:timezone 0.11.0 ready to publish timezone-v0.11.0

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@@ -0,0 +1,5 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a new package?

paths:
- '.github/workflows/timezone.yml'
- 'pkgs/timezone/**'
- 'pkgs/unix_api/**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to run the workflow when unix_api changes?

paths:
- '.github/workflows/timezone.yml'
- 'pkgs/timezone/**'
- 'pkgs/unix_api/**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to run the workflow when unix_api changes?

strategy:
fail-fast: false
matrix:
sdk: [dev]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to run on dev?

strategy:
fail-fast: false
matrix:
# Add macos-latest and/or windows-latest if relevant for this package.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this comment?

strategy:
fail-fast: false
matrix:
sdk: [dev]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to test on dev?

run: dart analyze --fatal-infos
if: always() && steps.install.outcome == 'success'

# Run tests on a matrix consisting of two dimensions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this comment?

strategy:
fail-fast: false
matrix:
# Add macos-latest and/or windows-latest if relevant for this package.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this comment?

chmod +x tool/refresh.sh
./tool/refresh.sh

- name: Check for git diff
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do this again? Isn't it done in the other workflow?

@@ -0,0 +1,81 @@
// Copyright (c) 2014, the timezone project authors. Please see the AUTHORS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this copyright OK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-infra A repository infrastructure change or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.