-
Notifications
You must be signed in to change notification settings - Fork 8
Merge timezone package #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for good practice and clean code I faced an inconvenienced because local time in my flutter app was changed unexpectedly. That was because initializeDatabase() function silently change _local to _UTC . using setLocalLocation() for that makes debugging easier
Clarified that package does not provide current timezone
…ation Make `Location.offset` a `Duration`
…nTZNames Generate common tz names
Tweaks and anti-bug-ensurence.
Replace direct assignment with setLocalLocation method.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
| @@ -0,0 +1,5 @@ | |||
| --- | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a new package?
| paths: | ||
| - '.github/workflows/timezone.yml' | ||
| - 'pkgs/timezone/**' | ||
| - 'pkgs/unix_api/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to run the workflow when unix_api changes?
| paths: | ||
| - '.github/workflows/timezone.yml' | ||
| - 'pkgs/timezone/**' | ||
| - 'pkgs/unix_api/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to run the workflow when unix_api changes?
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| sdk: [dev] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to run on dev?
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| # Add macos-latest and/or windows-latest if relevant for this package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this comment?
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| sdk: [dev] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to test on dev?
| run: dart analyze --fatal-infos | ||
| if: always() && steps.install.outcome == 'success' | ||
|
|
||
| # Run tests on a matrix consisting of two dimensions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this comment?
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| # Add macos-latest and/or windows-latest if relevant for this package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this comment?
| chmod +x tool/refresh.sh | ||
| ./tool/refresh.sh | ||
|
|
||
| - name: Check for git diff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to do this again? Isn't it done in the other workflow?
| @@ -0,0 +1,81 @@ | |||
| // Copyright (c) 2014, the timezone project authors. Please see the AUTHORS | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this copyright OK?
Allow merge commitsadmin setting)Contribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.