Skip to content

Conversation

brianquinlan
Copy link
Contributor

@brianquinlan brianquinlan commented Sep 5, 2025

  • Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added type-infra A repository infrastructure change or enhancement package:io_file labels Sep 5, 2025
@brianquinlan brianquinlan changed the title Extract the POSIX API into a separate package Extract the io_file POSIX API into a separate package Sep 6, 2025
@devoncarew
Copy link
Member

@brianquinlan - for the review - is this mostly a mechanical change? Create a new labs package, move content into it, and reference it from the existing package?

@brianquinlan
Copy link
Contributor Author

@brianquinlan - for the review - is this mostly a mechanical change? Create a new labs package, move content into it, and reference it from the existing package?

Yes. I added a very simple test (which I will improve in follow-up PRs) and a README file. Everything else is a move from the existing location or was created from dart create.

BTW, I don't actually want a good name for this package - hopefully someone will fork this and take whatever the best available name is ;-)

Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ some in-line comments

meta: ^1.16.0
native_toolchain_c: ^0.16.0
path: ^1.9.1
unix_api:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd try using something like ^0.1.0 here, and add a dependency_overrides section further down:

dependency_overrides:
  unix_api:
    path: ../unix_api

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed to back because changing this also trickles into the mobile_test subproject and it seemed better to contain the path reference here. WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it's not normally how we'd try and reference a package - it'll mean that io_file won't be useable outside this repo. I'm not sure what the issue is w/ the subproject.

Feel free to use your best judgement here though; we're not trying to ship this currently. If you do use a relative reference into this repo, you might leave a comment that this isn't our normal practice.

meta: ^1.16.0
native_toolchain_c: ^0.16.0
path: ^1.9.1
unix_api:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it's not normally how we'd try and reference a package - it'll mean that io_file won't be useable outside this repo. I'm not sure what the issue is w/ the subproject.

Feel free to use your best judgement here though; we're not trying to ship this currently. If you do use a relative reference into this repo, you might leave a comment that this isn't our normal practice.

@brianquinlan brianquinlan merged commit c6178cd into dart-lang:main Sep 11, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:io_file type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants