Skip to content

Conversation

@devoncarew
Copy link
Contributor

  • add an example use of firestore (example/example.dart)
  • add an API example to the readme

The example/example.dart file shows both simple value get and set, as well as an example of the streaming listen call.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

// generator doesn't yet parse the http proto annotations.
options: grpc.CallOptions(
metadata: {
'x-goog-request-params': 'database=$databaseId',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to replace this manual routing header w/ improvements to the grpc / protobuf generator so that it adds the necessary headers.

@devoncarew devoncarew requested a review from mosuem June 3, 2025 17:57

environment:
sdk: ^3.7.0
sdk: ^3.6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for downgrading?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question; I actually forget. perhaps to retain the current (pre-3.7) formatting?

I'll keep this as is and roll separately w/ a general proto-regenerate PR.

@devoncarew devoncarew merged commit 4cc1f78 into main Jun 11, 2025
6 checks passed
@devoncarew devoncarew deleted the add_example branch June 11, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants