No error if passing a VM service URI instead of a DTD uri

[jakemac53]

See thread here #66 (comment).

It seems like the connect to DTD tool will return success even if it ends up connecting to a VM service instead of a DTD service.

[jakemac53]

@kenzieschmoll any ideas how we might do this?

There is no real handshake or anything upon connection at the moment and adding a required one would be breaking...

[sigurdm]

Could the vm service uri somehow be used to produce a dtd uri, so things end up working?

[jakemac53]

We might be able to just gracefully handle being given either a DTD Uri or a VM service URI. Ultimately right now we only really need the VM service URI (but in the IDE, its easier to get a DTD Uri).

I think maybe we should just get some sort of entry point implemented by each of the services which just allows it to identify itself?

Basically we would then first connect assuming it was DTD, and then ask if its actually DTD, and if not reconnect assuming it is the VM service (or possibly hand off the existing connection).

[jakemac53]

cc @bkonyi thoughts on some sort of "identity" request?

[jakemac53]

This was fixed by #316 - we just make a getVM request and if it succeeds we assume we are connected to a VM Service. It isn't ideal but it is pragmatic.