Remote service enhancement (applied to updated SlimBrowse Metadata) #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: darrell-k <[email protected]>
Signed-off-by: darrell-k <[email protected]>
darrell-k
commented
Nov 9, 2025
| cover => $subFeed->{'cover'} || $subFeed->{'image'} || $subFeed->{'icon'} || $request->getParam('icon'), | ||
| year => $subFeed->{'year'}, | ||
| album => $subFeed->{'album'}, | ||
| artist => $subFeed->{'artist'}, |
Owner
Author
There was a problem hiding this comment.
Not sure about these _cliQuery_done changes: may be left over from my branch which included changes for Default and Classic skins?
darrell-k
commented
Nov 9, 2025
| 'sortBy' => $attributes->{$tag.'SORT'}, | ||
| # only store EXTID for track artist, as we don't have it for other roles | ||
| 'extid' => $tag eq 'ARTIST' && $attributes->{'ARTIST_EXTID'}, | ||
| 'extid' => $attributes->{"${tag}_EXTID"}, |
Owner
Author
There was a problem hiding this comment.
These Slim::Schema changes just ensure we populate *_EXTID for all roles for which we have it, certainly the Qobuz plugin provides extid for Composers, at least.
Could be made into a separate PR, hopefully uncontroversial?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.