This repository was archived by the owner on Dec 5, 2019. It is now read-only.
Restore support for .NET Framework 4.5.2 #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
read loupe types from Loupe.Agent.NETCore and Gibraltar.Agent
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #167, I would like to have support for .NET 4.5.2 restored using new project format.
The only IF-def I had to insert was for Loupe Agent, because there are two different packages for each framework. Moreover, I had to update Loupe provider in order to make it look for required types in both assemblies.
Unit tests for .NET 4.5.2 seem to be running fine.
I hope changes are good enough, let me know if there is something that I can improve.
Thanks!