AppCleaner: Fix automation timeout on apps with empty cache #2053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On OxygenOS 15 (and similar ROMs), the "Clear cache" button becomes both non-clickable and disabled when cache is 0 bytes. The automation was timing out because: 1. findClickableParent() returned null (no clickable parent exists) 2. The action bailed out early, never calling clickClearCache() 3. Even when reached, clickClearCache() didn't detect the 0-cache scenario properly Fixed by: - Falling back to the target button when no clickable parent is found - Adding detection for 0-cache scenario (button is not clickable AND disabled) in clickClearCache() The fix distinguishes between: - Size calculation: button is clickable but temporarily disabled → retry - Zero cache: button is not clickable and disabled → return success Closes #1889
d4rken
added
c: AppCleaner
Automation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OxygenOS 15 (and similar ROMs), the "Clear cache" button becomes both non-clickable and disabled when cache is 0 bytes. The automation was timing out because:
Fixed by:
The fix distinguishes between:
Closes #1889