Scheduler: Fix scheduled tasks shifting by 1 hour after DST transitions #2052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scheduled tasks now maintain correct local time across daylight saving time transitions. Previously, schedules set for 10:00 would shift to 11:00 (or 09:00) after DST changes. The fix stores the user's timezone when enabling a schedule and uses calendar arithmetic (plusDays) instead of duration arithmetic (plus(Duration)) for time calculations. This ensures local time is preserved even when UTC offsets change. Changes: - Added userZone field to Schedule for storing timezone at enable time - Changed from Duration to calendar arithmetic in calcExecutionEta - Added resolveZone() helper with fallback for invalid/missing timezones - Added DST-specific tests for spring forward and fall back scenarios Closes #768
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheduled tasks now maintain correct local time across daylight saving time transitions. Previously, schedules set for 10:00 would shift to 11:00 (or 09:00) after DST changes.
The fix stores the user's timezone when enabling a schedule and uses calendar arithmetic (plusDays) instead of duration arithmetic (plus(Duration)) for time calculations. This ensures local time is preserved even when UTC offsets change.
Changes:
Closes #768