AppCleaner: Use label-priority search for clear cache button detection #2048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OneUI Changed label matching to try candidates in priority order instead of finding any matching node first. This ensures the correct "Clear Cache" button is found even when other UI elements (like "Cache Memory" labels) match earlier in the node tree. Also simplified text matching extension functions using idiomatic Kotlin and added unit tests for coverage. Fixes #2046
Refactor all ROM specs to use the new `findNodeByLabel` extension function which searches by label priority rather than tree order. This ensures the correct button is found when multiple labels match (e.g., Polish localization where "Pamięć cache" label appears before "Wyczyść pamięć podręczną" button). Changes: - Add `findNodeByLabel` extension to StepperExtensions for label-priority search - Update 17 ROM specs to use label-priority search pattern - Remove reliance on tree-order node matching Closes #2046
Update `.claude/settings.json` to whitelist `git add`, `git log`, `git commit`, and `git show` commands for Bash execution.
Add unit tests for `StepContext.findNodeByLabel` to ensure correct handling of label search lists. Validates that the function respects the priority order of provided labels (matching specific labels before generic fallbacks) and correctly applies predicate filters. Changes: - Add `createStepContextWithTree` helper - Add tests for priority matching, fallback logic, predicate filtering, and empty inputs
d4rken
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor all ROM specs to use the new
findNodeByLabelextension functionwhich searches by label priority rather than tree order. This ensures the
correct button is found when multiple labels match (e.g., Polish localization
where "Pamięć cache" label appears before "Wyczyść pamięć podręczną" button).
Changes:
findNodeByLabelextension to StepperExtensions for label-priority searchCloses #2046