AppCleaner: Fix timeout when querying app size for large apps #2040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When querying storage stats for large apps (e.g., Spotify, Amazon Prime Video), the system call can take 15-20 seconds. Previously, the size query happened inside the step's retry loop with a 5-second inner timeout, causing premature cancellation. Changes: - Increase inner attempt timeout from 5s to 10s for UI navigation - Pre-compute size matcher before returning the storageFinder lambda, moving the 20s queryStatsForPkg call outside the step's retry loop entirely - Update timeout comment in AutomationStep to reflect actual values The size query now runs when storageFinderAOSP() is called (before the step is created), so retries only repeat the fast UI navigation, not the slow system query. Closes #2032
d4rken
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querying storage stats for large apps (e.g., Spotify, Amazon Prime Video), the system call can take 15-20 seconds. Previously, the size query happened inside the step's retry loop with a 5-second inner timeout, causing premature cancellation.
Changes:
The size query now runs when storageFinderAOSP() is called (before the step is created), so retries only repeat the fast UI navigation, not the slow system query.
Closes #2032