Automation: Increase step timeout and handle storage query timeouts #2003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default timeout for an automation step has been increased to 30 seconds. This prevents premature failures on slower devices, especially when querying storage stats for large applications, which can exceed the previous 15-second limit. Additionally, the `StorageEntryFinder` now enforces its own 20-second timeout for the `queryStatsForPkg` call. This ensures that if the system call hangs, the automation step can gracefully fail and proceed with recovery actions instead of getting stuck.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default timeout for an automation step has been increased to 30 seconds. This prevents premature failures on slower devices, especially when querying storage stats for large applications, which can exceed the previous 15-second limit.
Additionally, the
StorageEntryFindernow enforces its own 20-second timeout for thequeryStatsForPkgcall. This ensures that if the system call hangs, the automation step can gracefully fail and proceed with recovery actions instead of getting stuck.