Deduplicator: Fix file viewing issues when opening PDFs and other files #1976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created ViewIntentTool to centralize file viewing intent creation. Previously, opening files (especially PDFs) would fail with ActivityNotFoundException because: - Missing MIME type specification - Using raw file:// URIs instead of FileProvider content:// URIs - Missing FLAG_GRANT_READ_URI_PERMISSION The new tool properly: - Creates FileProvider URIs with correct authority - Determines and sets MIME types using MimeTypeTool - Adds necessary permission flags for external apps - Creates chooser intent for better UX - Returns null for unsupported path types Also refactored ContentViewModel to use the same logic, eliminating code duplication. Closes #1974
rannlangel
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created ViewIntentTool to centralize file viewing intent creation. Previously, opening files (especially PDFs) would fail with ActivityNotFoundException because:
The new tool properly:
Also refactored ContentViewModel to use the same logic, eliminating code duplication.
Closes #1974