AppCleaner: Fix automation issues on HyperOS/MIUI devices #1933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking if the Security Center app has PACKAGE_USAGE_STATS permission, MODE_DEFAULT was incorrectly treated as "permission denied". MODE_DEFAULT actually means "use default security check" and requires falling back to traditional permission checking via PackageManager.checkPermission(). For system apps like Security Center on HyperOS/MIUI, the permission might be granted through manifest declarations even when AppOps returns MODE_DEFAULT. Changes: - Add fallback permission check when MODE_DEFAULT is returned - Enhance logging with descriptive mode names for easier debugging - Add comprehensive documentation explaining MODE_DEFAULT behavior - Only treat MODE_IGNORED and MODE_ERRORED as explicit denials This should resolve automation failures where users got incorrect "Security Center missing permission" errors when the permission was actually available. Closes #1827
Added comprehensive commit message guidelines to help write better commits: - Clear format structure with module prefixes - User-friendly title guidelines for changelog visibility - Module prefixes for all SD Maid SE cleaning tools - Examples of good vs bad commit messages - Technical details best practices This will ensure future commits have user-friendly titles for changelogs while keeping technical implementation details in the commit body.
d4rken
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking if the Security Center app has PACKAGE_USAGE_STATS permission,
MODE_DEFAULT was incorrectly treated as "permission denied". MODE_DEFAULT actually
means "use default security check" and requires falling back to traditional
permission checking via PackageManager.checkPermission().
For system apps like Security Center on HyperOS/MIUI, the permission might be
granted through manifest declarations even when AppOps returns MODE_DEFAULT.
Changes:
This should resolve automation failures where users got incorrect "Security Center
missing permission" errors when the permission was actually available.
Closes #1827