Test: Refine SegmentCriterium path matching
#1929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`basePath.child("abc", "/")` created an invalid test case as `/` can not be the name of a child.
This commit removes a redundant test case from `SystemCrawlerSieveTest` that was already covered by `SegmentCriteriumTest`.
It also adds new test cases to `SegmentCriteriumTest` to verify correct matching of paths ending with a separator, especially when `allowPartial = true`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basePath.child("abc", "/")created an invalid test case as/can not be the name of a child.This commit removes a redundant test case from
SystemCrawlerSieveTestthat was already covered bySegmentCriteriumTest. It also adds new test cases toSegmentCriteriumTestto verify correct matching of paths ending with a separator, especially whenallowPartial = true.