Improve CorpseFinder support for rooted Android 16 devices #1915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4rken
added
enhancement
This commit modifies the API level check in `AppLibCorpseFilter`. The filter is now skipped on API level 35 and above, as newer Android versions use a different directory structure for app libraries. This change is based on the findings in issue #1612.
This commit adds a test case to ensure that `DalvikProfileCSI` correctly ignores ART profile paths introduced in Android 16. These paths should not be handled by this component.
This commit adds clutter markers for preinstall history and package path files created by the MIUI package installer. These files are located in the app-specific app data area. Corresponding tests have been added to verify these markers.
This test was commented out and is no longer needed.
This commit introduces a new section to `CLAUDE.md` detailing the project's testing guidelines. It covers framework selection (JUnit 5 for unit tests, JUnit 4 for Robolectric), base test classes, common testing patterns with examples, recommended testing libraries, test organization principles, and common test utilities.
This commit enhances the package name extraction logic for Android 11 and newer versions. When the path contains two segments (e.g., `~~HASH==/pkg-HASH==`), the package name is now directly extracted from the second segment. This avoids an unnecessary and potentially failing filesystem listing (`listFiles`). For paths with a single segment (e.g., `~~HASH==`), the existing behavior of listing the directory contents to find the package name is retained as a fallback. This change optimizes the process for the common double-hash pattern and improves robustness.
This commit introduces unit tests for `AppSourceClutterCheck` to verify its behavior in various scenarios, including: - No clutter match - Specific MIUI preinstall file mappings - Multiple package name associations - Clutter matches with custodian flags - Multiple clutter matches for a single file
This commit enhances `AppSourceMainCSITest` by: - Adding test cases for Android 11's double-hashed standard package paths. - Including tests for versioned Trichrome library package paths. - Testing identification of Trichrome library APKs under various path structures. - Verifying that `vmdl*.tmp` directories and their contents are correctly identified as having no owner and being blacklisted (corpses).
d4rken
force-pushed
the
corpsefinder-android16
branch
from
aa1ad5a to
ba75d95
Compare
This was referenced Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.