AppControl: Fix duplicate entries when changing app states #1908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls for packages with multiple users.
…reshing app data for a single package ID, we also need to only return those for the current user, otherwise we may display more data than we previously loaded via "allApps", seemingly duplicating entries. Fixes #1907
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On rooted or Shizuku devices, SD Maid has access to app installs from other users/profiles.
Normally only the apps of the current user are displayed in the list.
The update logic after enabling/disabling an app, did not filter out app data from other users.
So after changing the enabled/disabled state of an app that was installed for other users, suddenly duplicate entries appeared that couldn't be opened.
These extra entries will no longer appear, and if they do, they will not be openable.
I'm considering enabling multi user display in another feature PR.
Fixes #1907