AppCleaner: Support for detecting weird button setups in custom ROMs #1897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1885 Also introduce ACSNodeInfo interface for accessibility nodes This commit introduces an `ACSNodeInfo` interface to abstract `AccessibilityNodeInfo`. This change improves testability by allowing mock implementations and prepares for potential future support of other accessibility frameworks. All usages of `AccessibilityNodeInfo` have been updated to use `ACSNodeInfo`. Basic tests for new `findClickableSibling` and `findClickableParent` methods are also added.
This commit introduces unit tests for the `clickNormal` extension function in `StepperExtensions.kt`. It also modifies `TestACSNodeInfo.kt` to track performed actions, enabling more robust testing of action-related logic.
This commit introduces a comprehensive test suite for the `AccessibilityNodeExtensions.kt` file. It covers various extension functions for `ACSNodeInfo` and `AccessibilityEvent`. Key areas tested: - Text matching (`textVariants`, `textMatchesAny`, `textContainsAny`, `textEndsWithAny`) - ID matching (`idMatches`, `idContains`) - Node type checks (`isClickyButton`, `isTextView`, `isRadioButton`) - Node traversal and hierarchy (`children`, `findParentOrNull`, `getRoot`, `crawl`) - Node actions (`scrollNode`) - `AccessibilityEvent.pkgId` extension The tests utilize a mock `TestACSNodeInfo` class (which was also slightly modified to be an open class and override equals/hashCode for better testability) to simulate different node states and properties.
d4rken
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1885