Settings: Use Material Design for ListPreference dialogs #1883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces `MaterialListPreference` to ensure that `ListPreference` dialogs in settings screens use Material Design components. Key changes: - Created `MaterialListPreference` which extends `ListPreferenceDialogFragmentCompat` and uses `MaterialAlertDialogBuilder` to construct the dialog. - Updated `PreferenceFragment3` to override `onDisplayPreferenceDialog` and display `MaterialListPreference` when a `ListPreference` is encountered. - Modified `GeneralSettingsFragment.kt` to import and potentially use `MaterialListPreference` (though no direct usage change is visible in this diff). This change ensures a consistent Material Design look and feel across all preference dialogs. Closes #1880
d4rken
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces
MaterialListPreferenceto ensure thatListPreferencedialogs in settings screens use Material Design components.Key changes:
MaterialListPreferencewhich extendsListPreferenceDialogFragmentCompatand usesMaterialAlertDialogBuilderto construct the dialog.PreferenceFragment3to overrideonDisplayPreferenceDialogand displayMaterialListPreferencewhen aListPreferenceis encountered.GeneralSettingsFragment.ktto import and potentially useMaterialListPreference(though no direct usage change is visible in this diff).This change ensures a consistent Material Design look and feel across all preference dialogs.
Closes #1880