Prevent Google Play errors from crashing SD Maid #1875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UpgradeRepo could throw an error which would people up (after 7 days grace period) and hit the app-level coroutine scope, which could crash the app. Let's catch that error, default to "isPro=false", and if the user visits the upgrade screen, show error specifics.
This commit introduces a retry mechanism with exponential backoff for fetching upgrade information. If there's an error and the last pro state was recent (within 7 days), it enters a grace period and emits cached data. Otherwise, it emits an error.
This change introduces a flag to ensure that an error message on the upgrade screen is only shown once to the user, even if the underlying error state persists across configuration changes or other lifecycle events.
This commit refactors the error handling logic in the `UpgradeViewModel` for both Gplay and FOSS versions. It extracts the error object into a local variable before using it, improving code readability. Smartcast issue: > Expected non-nullable value [NullSafeMutableLiveData from androidx.lifecycle]
Deniz8179
approved these changes
Jul 23, 2025
Deniz8179
approved these changes
Jul 23, 2025
Deniz8179
approved these changes
Jul 23, 2025
Deniz8179
approved these changes
Jul 23, 2025
This commit resolves a linter warning related to unnecessary null assertions in both the gplay and foss variants of `UpgradeViewModel`. The warning was suppressed as it was identified as a linter bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UpgradeRepo could throw an error which would people up (after 7 days grace period) and hit the app-level coroutine scope, which could crash the app.
Let's catch that error, default to "isPro=false", and if the user visits the upgrade screen, show error specifics.