Refactor: Improve PreferenceStoreMapper key lookup #1865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes crash when accessing string keys with a null value - Throw `NotImplementedError` directly in `byKey` if a `DataStoreValue` for the given key is not found. - Remove redundant `NotImplementedError` throws in getter/setter methods as `byKey` now handles this. - Simplify getter/setter logic by removing nullable checks, relying on `byKey`'s non-null return or exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crash when accessing string keys with a null value
NotImplementedErrordirectly inbyKeyif aDataStoreValuefor the given key is not found.NotImplementedErrorthrows in getter/setter methods asbyKeynow handles this.byKey's non-null return or exception.