Skip to content

feat(scaffold): typed-query-selectorの追加 #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arktds wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

feat(scaffold): typed-query-selectorの追加 #53

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40a46e0
feat(scaffold): typed-query-selectorの追加
arktds Jun 14, 2024
17ef177
feat(scaffold): typed-query-selectorの有効化
arktds Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/@d-zero/scaffold/__assets/_libs/script/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// querySelector() または querySelectorAll() を実行する場合、次の import 文を有効にしてください。
// import 'typed-query-selector/strict.js';

Copy link
Member

@YusukeHirao YusukeHirao Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arktds

デフォルト有効でいいと思います。
ガイドラインにIssueを立てて、利用するように促しましょう。

Copy link
Author

@arktds arktds Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

querySelector() または querySelectorAll() を実行しない場合、無駄なインポートになる（ビルド後にコードはバンドルされませんが）かなと思いコメントアウトしました。
とはいえ、たしかにほとんどの場合実行すると思うので、有効にします！

ガイドラインでも促します！

export function helloWorld() {
console.log('Hello, world!'); // eslint-disable-line no-console
}
1 change: 1 addition & 0 deletions packages/@d-zero/scaffold/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"cross-env": "7.0.3",
"npm-run-all2": "6.2.0",
"sass": "1.77.5",
"typed-query-selector": "2.11.2",
"typescript": "5.4.5"
},
"dependencies": {
Expand Down
5 changes: 5 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11797,6 +11797,11 @@ [email protected]:
resolved "https://registry.yarnpkg.com/typed-function/-/typed-function-0.10.7.tgz#f702af7d77a64b61abf86799ff2d74266ebc4477"
integrity sha512-3mlZ5AwRMbLvUKkc8a1TI4RUJUS2H27pmD5q0lHRObgsoWzhDAX01yg82kwSP1FUw922/4Y9ZliIEh0qJZcz+g==

[email protected]:
version "2.11.2"
resolved "https://registry.yarnpkg.com/typed-query-selector/-/typed-query-selector-2.11.2.tgz#30f9a2d7d51fc08781b277dff91c61aa8dd756c3"
integrity sha512-6rZP+cG3wPg2w1Zqv2VCOsSqlkGElrLSGeEkyrIU9mHG+JfQZE/6lE3oyQouz42sTS9n8fQXvwQBaVWz6dzpfQ==

typedarray.prototype.slice@^1.0.3:
version "1.0.3"
resolved "https://registry.yarnpkg.com/typedarray.prototype.slice/-/typedarray.prototype.slice-1.0.3.tgz#bce2f685d3279f543239e4d595e0d021731d2d1a"
Expand Down