Skip to content

Conversation

@ermajn
Copy link
Contributor

@ermajn ermajn commented Jul 23, 2024

This enables usage of pgbackrest inside of container in terms of automatic backups (full and incr) using cron.
It is also possible to do restore using clone with pgbackrest.
Cron is running in non-privileged mode.

@ermajn ermajn requested review from Schmaetz and ants July 23, 2024 10:15
Copy link
Collaborator

@Schmaetz Schmaetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ermajn ,
Thank you for your PR.
The problem with the clone script is that you are ignoring the use of pgBackRest via repo host. This means that your script ‘only’ works with s3, gcs or azure blob.
You would have to correct this. I.e. the pgbackrest server must be started before the restore.
I am also not really convinced by the use of cron in the container. What speaks against the usual way, which is also followed by the operator, that there is a pgbackrest container, which is started in backup mode and then contacts the corresponding container and sends the backup command?
This container can then be based on the cron from the docker host.

Currently this is still based on ssh, but will be replaced by a tls module in the future.

Best regards
Matthias

Copy link
Collaborator

@Schmaetz Schmaetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side :)
Can you check this too please @ants?

@ermajn
Copy link
Contributor Author

ermajn commented Jul 30, 2024

@Schmaetz @ants some changes are comming in, so pls. wait for those...

@ermajn
Copy link
Contributor Author

ermajn commented Aug 2, 2024

@Schmaetz @ants please review

@Schmaetz Schmaetz merged commit d694ab5 into main Nov 18, 2024
@Schmaetz Schmaetz deleted the CON-878 branch November 18, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants