-
Notifications
You must be signed in to change notification settings - Fork 0
CON-878 #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Schmaetz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ermajn ,
Thank you for your PR.
The problem with the clone script is that you are ignoring the use of pgBackRest via repo host. This means that your script ‘only’ works with s3, gcs or azure blob.
You would have to correct this. I.e. the pgbackrest server must be started before the restore.
I am also not really convinced by the use of cron in the container. What speaks against the usual way, which is also followed by the operator, that there is a pgbackrest container, which is started in backup mode and then contacts the corresponding container and sends the backup command?
This container can then be based on the cron from the docker host.
Currently this is still based on ssh, but will be replaced by a tls module in the future.
Best regards
Matthias
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side :)
Can you check this too please @ants?
This enables usage of pgbackrest inside of container in terms of automatic backups (full and incr) using cron.
It is also possible to do restore using clone with pgbackrest.
Cron is running in non-privileged mode.