Skip to content

Conversation

@davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Aug 19, 2024

🤔 What's changed?

Removes some long-deprecated exports from the main entry point:

  • Runtime
  • parseGherkinMessageStream
  • PickleFilter

⚡️ What's your motivation?

The time has come for all of these, but Runtime in particular is the subject of a rewrite in #2419.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • 💥 Breaking change (incompatible changes to the API)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Aug 19, 2024

Coverage Status

coverage: 97.929% (-0.02%) from 97.946%
when pulling dd90b76 on feat/remove-runtime
into dc03f16 on main.

@davidjgoss davidjgoss marked this pull request as ready for review August 21, 2024 12:00
@davidjgoss davidjgoss merged commit aa3ce7b into main Aug 21, 2024
@davidjgoss davidjgoss deleted the feat/remove-runtime branch August 21, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants