Skip to content

Conversation

@asashour
Copy link
Contributor

@asashour asashour commented Apr 9, 2024

🤔 What's changed?

Part of #1648

⚡️ What's your motivation?

To learn about the project and to learn TypeScript.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

For the next set of changes

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Apr 9, 2024

Coverage Status

coverage: 98.392%. remained the same
when pulling ee05077 on asashour:type1
into 7f4999b on cucumber:main.

Copy link
Contributor

@davidjgoss davidjgoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress already, thanks @asashour

@davidjgoss davidjgoss merged commit 28683b3 into cucumber:main Apr 21, 2024
@asashour asashour deleted the type1 branch April 21, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants