Skip to content

[LTS 8.8-rt] github actions: Make builds on Merge Request #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

PlaidCat
Copy link
Collaborator

Since we need to make sure external contributors code actually compiles prior to merging. To get access to the forked repos merge request we need to switch over our push to pull_request. In addition we're fixing up some Naming Conventions, adding aarch64 to this branch and fixing the naming so that we can quickly identify if the CI is for x86_64 or aarch64.

Reference builds:
#85

Since we need to make sure external contributors code actually compiles prior
to merging. To get access to the forked repos merge request we need to switch
over our push to pull_request. In addition we're fixing up some Naming
Conventions, adding aarch64 to this branch and fixing the naming so that we can
quickly identify if the CI is for x86_64 or aarch64.
@PlaidCat PlaidCat self-assigned this Jan 27, 2025
@bmastbergen
Copy link
Collaborator

Is aarch64 check missing on purpose? I notice we do check aarch64 on 9.2-rt. Maybe we missed it in 8.6-rt as well? #89

@PlaidCat
Copy link
Collaborator Author

Is aarch64 check missing on purpose? I notice we do check aarch64 on 9.2-rt. Maybe we missed it in 8.6-rt as well? #89

Yes, we don't support it and it doesn't compile in LTS8.6 and LTS8.8 RTs in the current method ... more investigation is needed if we even want to spend the Resources for RT on an aarch we're not supporting.

@bmastbergen
Copy link
Collaborator

Is aarch64 check missing on purpose? I notice we do check aarch64 on 9.2-rt. Maybe we missed it in 8.6-rt as well? #89

Yes, we don't support it and it doesn't compile in LTS8.6 and LTS8.8 RTs in the current method ... more investigation is needed if we even want to spend the Resources for RT on an aarch we're not supporting.

Ok cool. Just doublechecking.

Copy link

@gvrose8192 gvrose8192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@PlaidCat PlaidCat merged commit 81aa6b3 into ciqlts8_8-rt Jan 27, 2025
1 check passed
@PlaidCat PlaidCat deleted the {jmaple}_ciqlts8_8-rt branch January 27, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants