[LTS 8.6] selftests: reuseaddr_conflict: add missing new line at the end of the output #385
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvts-mat
force-pushed
the
ciqlts8_6-kselftests-reuseaddr_conflict-format-fix
branch
from
c7851c1 to
4109806
Compare
pvts-mat
changed the title
This was referenced Jul 1, 2025
PlaidCat
reviewed
Jul 2, 2025
There was a problem hiding this comment.
did this get indented some how?
commit-author Jakub Kicinski <[email protected]>
commit https://github.com/ctrliq/kernel-src-tree/commit/31974122cfdeaf56abc18d8ab740d580d9833e90
I would prefer them to be aligned to start of line.
Otherwise this looks good and I"m glad there is a blank line between the header and the body summary from upstream.
PlaidCat
requested review from
kerneltoast,
PlaidCat,
bmastbergen,
thefossguy-ciq and
shreeya-patel98
Oops, sorry. No intent for the indent. Let me fix that real quick |
… output commit-author Jakub Kicinski <[email protected]> commit 3197412 The netdev CI runs in a VM and captures serial, so stdout and stderr get combined. Because there's a missing new line in stderr the test ends up corrupting KTAP: # Successok 1 selftests: net: reuseaddr_conflict which should have been: # Success ok 1 selftests: net: reuseaddr_conflict Fixes: 422d8dc ("selftest: add a reuseaddr test") Reviewed-by: Muhammad Usama Anjum <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]> (cherry picked from commit 3197412) Signed-off-by: Marcin Wcisło <[email protected]>
pvts-mat
force-pushed
the
ciqlts8_6-kselftests-reuseaddr_conflict-format-fix
branch
from
4109806 to
a108827
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[LTS 8.6]
About
This commit fixes bad formatting for the
net:reuseaddr_conflicttest, which prevents automated tools from extracting the test's status.Before:
After:
That it's a proper place for the newline (and not in some script executing the
reuseaddr_conflictbinary, for example) see similar tests from the same collection, eg:kernel-src-tree/tools/testing/selftests/net/reuseport_addr_any.c
Lines 270 to 278 in 499f93a
kernel-src-tree/tools/testing/selftests/net/reuseport_bpf.c
Lines 639 to 640 in 499f93a
PS
Turned out there is already a 3197412 fix in the mainline targeting exactly this issue. Switched to that commit's cherry-pick instead of the manual change.