Skip to content

Commit 1dce520

Browse files
Jinjie RuanPaolo Abeni
authored andcommitted
net: phy: Use for_each_available_child_of_node_scoped()
Avoid need to manually handle of_node_put() by using for_each_available_child_of_node_scoped(), which can simplfy code. Reviewed-by: Andrew Lunn <[email protected]> Reviewed-by: Jonathan Cameron <[email protected]> Signed-off-by: Jinjie Ruan <[email protected]> Reviewed-by: Florian Fainelli <[email protected]> Signed-off-by: Paolo Abeni <[email protected]>
1 parent 51c8842 commit 1dce520

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/net/phy/phy_device.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3407,7 +3407,7 @@ static int of_phy_led(struct phy_device *phydev,
34073407
static int of_phy_leds(struct phy_device *phydev)
34083408
{
34093409
struct device_node *node = phydev->mdio.dev.of_node;
3410-
struct device_node *leds, *led;
3410+
struct device_node *leds;
34113411
int err;
34123412

34133413
if (!IS_ENABLED(CONFIG_OF_MDIO))
@@ -3420,10 +3420,9 @@ static int of_phy_leds(struct phy_device *phydev)
34203420
if (!leds)
34213421
return 0;
34223422

3423-
for_each_available_child_of_node(leds, led) {
3423+
for_each_available_child_of_node_scoped(leds, led) {
34243424
err = of_phy_led(phydev, led);
34253425
if (err) {
3426-
of_node_put(led);
34273426
phy_leds_unregister(phydev);
34283427
return err;
34293428
}

0 commit comments

Comments
 (0)